It would be nice if html-proofer supported multiple html validators like vnu. My current setup disables html validation via proofer and instead uses vnu for that.

It would be nice if html-proofer supported multiple html validators like vnu. My current setup disables html validation via proofer and instead uses vnu for that.

That's a pretty good idea. It might be a pain to integrate a Java executable into this Ruby library though.

Hey @gjtorikian. Was wondering if there's anything currently in the way of merging this.

@geobrando Sorry! This is now out in 2.4.0: https://github.com/gjtorikian/html-proofer/releases/tag/v2.4.0

Thanks!

@gjtorikian

I'm wondering if I'm missing something. Either I don't know what I'm doing or there is something wrong with the tests.

  ruby:
    interpreter:  "ruby"
    version:      "2.1.2p95"
    date:         "2014-05-08"
    platform:     "i686-linux"
    patchlevel:   "2014-05-08 revision 45877"
    full_version: "ruby 2.1.2p95 (2014-05-08 revision 45877) [i686-linux]"

require 'bundler/inline'

gemfile(true) do
  source 'https://rubygems.org'
  gem 'html-proofer', github: 'gjtorikian/html-proofer', :tag => 'v2.4.2'
end    

HTML::Proofer.new("./files",{:check_html => true, :ignore_script_embeds => true}).run

running with the fixture in /files yields

- ./files/repo-test.html
  *  Element script embeds close tag (line 2)
  *  Element script embeds close tag (line 2)
/home/geobrando/.rvm/gems/ruby-2.1.2/bundler/gems/html-proofer-f1f645f19a87/lib/html/proofer.rb:190:in `print_failed_tests': HTML-Proofer found 2 failures! (RuntimeError)
    from /home/geobrando/.rvm/gems/ruby-2.1.2/bundler/gems/html-proofer-f1f645f19a87/lib/html/proofer.rb:92:in `run'
    from /home/geobrando/Projects/htmlproofer-testing/test.rb:8:in `<main>'

Hey @gjtorikian. Is this working as intended?

I'm also still seeing the Element script embeds close tag errors when I have this new option enabled, running 2.5.1 latest. Same as @geobrando with check_html and ignore_script_embeds both true.

The documentation is wrong, but the feature is working. The options should be passed like this:

opts = { :check_html => true, :validation => { :ignore_script_embeds => true } }

That is, within the :validation namespace (because I anticipated future options).

@gjtorikian Ah. You are correct. Looking at the binary, I think something needs to be changed to produce the proper namespaced option when using --ignore-script-embeds on the CL but I couldn't figure out how to do it.

From my limited knowledge of ruby it looks like you're mapping the CL flags directly to options that you pass to HTML:proofer. I'll let you figure out how to do this as I assume you'd have to take into account adding additional options in the :validation namespace.